fix: align POSTGRES_DB in prisma docker-compose with .env.example#28638
fix: align POSTGRES_DB in prisma docker-compose with .env.example#28638officialasishkumar wants to merge 3 commits intocalcom:mainfrom
Conversation
The development docker-compose file at packages/prisma/docker-compose.yml was configured with POSTGRES_DB set to "cal-saml", which is the SAML database name. This causes a mismatch with .env.example which specifies DATABASE_URL pointing to a database named "calendso". When a contributor runs `yarn dx` with a fresh Docker volume, Docker creates a database named "cal-saml", but Prisma migrations target the "calendso" database from .env.example, leading to connection failures or silent inconsistencies. The root-level docker-compose.yml already correctly uses "calendso". This change makes the prisma-specific docker-compose consistent with both .env.example and the root docker-compose.yml. Fixes calcom#28635 Fixes calcom#28106
|
This PR has been marked as stale due to inactivity. If you're still working on it or need any help, please let us know or update the PR to keep it active. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThis pull request updates the Docker Compose configuration for the Postgres container in the Prisma package. The 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
What does this PR do?
The development docker-compose file at
packages/prisma/docker-compose.ymlhadPOSTGRES_DBset to"cal-saml", which is the SAML database name. This creates a mismatch with.env.example, which setsDATABASE_URLpointing to a database named"calendso".When a contributor runs
yarn dxwith a fresh Docker volume, Docker creates a database namedcal-saml, but Prisma migrations target thecalendsodatabase (from.env.example), leading to connection failures.The root-level
docker-compose.ymlalready correctly uses"calendso". This one-line change makes the prisma-specific docker-compose consistent with both.env.exampleand the root-leveldocker-compose.yml.Visual Demo (For contributors especially)
N/A — configuration-only change with no UI impact.
Mandatory Tasks (DO NOT REMOVE)
How should this be tested?
docker compose -f packages/prisma/docker-compose.yml down -v.env.exampleto.env(or verifyDATABASE_URLpoints tolocalhost:5450/calendso)yarn dxto start Docker and run Prisma migrationscalendsois created and migrations succeed without errorspsql -h localhost -p 5450 -U postgres -lshows a database namedcalendso(notcal-saml)